Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(camera_view_plugin): add camera view plugin package #5472

Merged
merged 8 commits into from
Nov 6, 2023
Merged

feat(camera_view_plugin): add camera view plugin package #5472

merged 8 commits into from
Nov 6, 2023

Conversation

Owen-Liuyuxuan
Copy link
Contributor

@Owen-Liuyuxuan Owen-Liuyuxuan commented Nov 2, 2023 •
edited by tkimura4
Loading

Description

In testing the system, sometimes frequently switching from a third-person view following the vehicle and a bird-eye view focusing on the vehicle is needed.

This PR adds two buttons RViz plugin for convenient switching between the two views.

Related links

#5469

Tests performed

PSim

image
image

Notes for reviewers

Interface changes

Because operation view only makes sense when it is looking at the vehicle. So in code we force the target frame of operation view being base_link .

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Owen-Liuyuxuan added 2 commits November 2, 2023 17:20
add camera view plugin package
2ef981e 
Signed-off-by: Owen-Liuyuxuan <[email protected]>
add readme for short cut
ada714d 
Signed-off-by: Owen-Liuyuxuan <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 2, 2023
@shmpwk shmpwk requested review from shmpwk and Naophis November 2, 2023 09:49
@tkimura4
Copy link
Contributor

tkimura4 commented Nov 2, 2023

@Owen-Liuyuxuan
Could you change the file name and plugin name to more generic name?

ex.
operation_view -> third_person_view
route_set_view -> bird_eye_view

Owen-Liuyuxuan and others added 2 commits November 2, 2023 18:18
@tkimura4 tkimura4 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 3, 2023
@tkimura4 tkimura4 enabled auto-merge (squash) November 3, 2023 02:00
fix license
bf7c3e8 
Signed-off-by: Owen-Liuyuxuan <[email protected]>
auto-merge was automatically disabled November 3, 2023 05:41

Head branch was pushed to by a user without write access

@Owen-Liuyuxuan
Copy link
Contributor Author

@tkimura4 Sorry I may have interrupted the auto-merge with a commit to fixing the license problem.

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

Attention: 339 lines in your changes are missing coverage. Please review.

Comparison is base (5fc1bd8) 14.84% compared to head (f1786b9) 14.80%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5472      +/-   ##
==========================================
- Coverage   14.84%   14.80%   -0.05%     
==========================================
  Files        1665     1672       +7     
  Lines      116233   116572     +339     
  Branches    36257    36257              
==========================================
  Hits        17259    17259              
- Misses      79474    79813     +339     
  Partials    19500    19500
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.84% <ø> (ø) Carriedforward from bf7c3e8

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...w_rviz_plugin/src/third_person_view_controller.hpp 0.00% <0.00%> (ø)
...camera_view_rviz_plugin/src/bird_eye_view_tool.hpp 0.00% <0.00%> (ø)
...ra_view_rviz_plugin/src/third_person_view_tool.hpp 0.00% <0.00%> (ø)
...camera_view_rviz_plugin/src/bird_eye_view_tool.cpp 0.00% <0.00%> (ø)
...ra_view_rviz_plugin/src/third_person_view_tool.cpp 0.00% <0.00%> (ø)
...w_rviz_plugin/src/third_person_view_controller.cpp 0.00% <0.00%> (ø)
..._view_rviz_plugin/src/bird_eye_view_controller.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmpwk
Copy link
Contributor

shmpwk commented Nov 3, 2023

@Owen-Liuyuxuan
Could you check https://github.com/autowarefoundation/autoware.universe/actions/runs/6741712068/job/18326863638?pr=5472 ?

fix license
f03927a 
Signed-off-by: Owen-Liuyuxuan <[email protected]>
@Owen-Liuyuxuan
Copy link
Contributor Author

Owen-Liuyuxuan commented Nov 3, 2023 •
edited
Loading

@Owen-Liuyuxuan Could you check https://github.com/autowarefoundation/autoware.universe/actions/runs/6741712068/job/18326863638?pr=5472 ?

@shmpwk
I know that normalise should considered as a common spelling error that needs to be fixed. But it seems to be a library function https://www.ogre3d.org/docs/api/1.7/class_ogre_1_1_vector3.html#a9e572a5cc4e1ed826839e5281d8f1d3b

tier4/autoware-spell-check-dict#634

@Owen-Liuyuxuan Owen-Liuyuxuan mentioned this pull request Nov 3, 2023
Merged
@tkimura4
Copy link
Contributor

tkimura4 commented Nov 6, 2023

The spell-check-partial action succeeded.
https://github.com/autowarefoundation/autoware.universe/actions/runs/6742722495/job/18387566275?pr=5472

@tkimura4 tkimura4 merged commit 6b0a81f into autowarefoundation:main Nov 6, 2023
19 of 23 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Nov 7, 2023
@Owen-Liuyuxuan @pre-commit-ci @kyoichi-sugahara
feat(camera_view_plugin): add camera view plugin package (autowarefou…
55b5564 
…ndation#5472)

* add camera view plugin package

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* add readme for short cut

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* style(pre-commit): autofix

* change name

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* style(pre-commit): autofix

* fix license

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* fix license

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmpwk shmpwk shmpwk left review comments

@tkimura4 tkimura4 tkimura4 approved these changes

@Naophis Naophis Awaiting requested review from Naophis

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Owen-Liuyuxuan @tkimura4 @shmpwk @xmfcx